fix(cli): doctor check uses v2 task schedule instead of removed v1 user_memories key#219
Merged
ualtinok merged 1 commit intoJul 8, 2026
Conversation
…er_memories key The section-7 check read `dreamer.user_memories.enabled`, a v1 key migrated to `dreamer.tasks["review-user-memories"].schedule` in v2. The default-true logic always fired when `dreamer.disable=true`, and the warning referenced a non-existent setting. Now matches the runtime gate in task-config.ts.
There was a problem hiding this comment.
Pull request overview
Updates the OpenCode CLI doctor compatibility check for user-memories + dreamer so it aligns with Dreamer v2 configuration, avoiding false warnings and pointing users to the correct setting.
Changes:
- Extracted the compatibility logic into
checkUserMemoriesDreamerCompatibility()for reuse and unit testing. - Switched the check from legacy
dreamer.user_memories.enabled(v1) to v2 task gating viadreamer.tasks["review-user-memories"].schedule. - Updated the warning text and added targeted unit tests for the new helper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/cli/src/commands/doctor-opencode.ts | Replaces the legacy v1 user-memories config check with a v2 task-schedule-based compatibility check and updated warning message. |
| packages/cli/src/commands/doctor-opencode.test.ts | Adds unit tests validating the new compatibility helper across enabled/disabled and missing/empty schedule scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220.
Problem
The doctor check (section 7) read
dreamer.user_memories.enabled, a v1 config keythat was migrated to
dreamer.tasks["review-user-memories"].schedulein v2. AftermigrateDreamerV2ForDoctor runs and writes back, the key is gone from the file. The
default-true logic (
undefined !== false) always fired the warning whendreamer.disable=true, and the message told users to set a non-existent setting.Fix
checkUserMemoriesDreamerCompatibility()dreamer.tasks["review-user-memories"].schedule(matches runtime gate in task-config.ts)Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Fixes the doctor CLI check to use the v2 task schedule instead of the removed v1
user_memorieskey, preventing false warnings whendreamer.disable=true. The warning now points to the correct v2 setting and matches runtime gating.dreamer.tasks["review-user-memories"].scheduleand ignore legacydreamer.user_memories.dreamer.disable=true.checkUserMemoriesDreamerCompatibility()and added 8 unit tests.Written for commit 7c0c3ee. Summary will update on new commits.
Greptile Summary
This PR updates the OpenCode doctor check for the v2 dreamer task config.
review-user-memoriesanddreamer.disablecompatibility.dreamer.tasks["review-user-memories"].scheduleinstead of the old v1 key.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(cli): doctor check uses v2 task sche..." | Re-trigger Greptile